feat: implement vanishing argument #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO, it's better to change |
|
e5eb6c0 should bring changes to |
|
Could you specific Verifier link with permanent one dd0a61d? |
|
Could you split data structures in dd0a61d like any others? |
chokobole
reviewed
Dec 11, 2023
Insun35
reviewed
Dec 11, 2023
TomTaehoonKim
force-pushed
the
feat/implement-vanishing-argument
branch
6 times, most recently
from
7b8ab2d
to
a0c5983
Compare
|
Could you use type alias throughout a0c5983? |
chokobole
reviewed
Dec 12, 2023
TomTaehoonKim
force-pushed
the
feat/implement-vanishing-argument
branch
from
a0c5983
to
f7961df
Compare
TomTaehoonKim
force-pushed
the
feat/implement-vanishing-argument
branch
from
f7961df
to
73b60da
Compare
|
Could you replace all with |
chokobole
reviewed
Dec 14, 2023
Insun35
reviewed
Dec 14, 2023
TomTaehoonKim
force-pushed
the
feat/implement-vanishing-argument
branch
from
73b60da
to
fb670ea
Compare
TomTaehoonKim
force-pushed
the
feat/implement-vanishing-argument
branch
from
fb670ea
to
faf1510
Compare
See [Prover](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/plonk/vanishing/prover.rs#L19-L174) and [Verifier](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/plonk/vanishing/verifier.rs#L18-L138).
TomTaehoonKim
force-pushed
the
feat/implement-vanishing-argument
branch
from
faf1510
to
858b2d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements vanishing argument for both the prover side and the verifier side.
See: https://github.com/kroma-network/halo2/blob/dev/halo2_proofs/src/plonk/vanishing/prover.rs, https://github.com/kroma-network/halo2/blob/dev/halo2_proofs/src/plonk/vanishing/verifier.rs
Note that there is no test for the verifier side and the data integrity test has not been done yet.