chore(zk): add comment for ownership representation

kroma-network · Dec 4, 2023 · c92eafb · c92eafb
1 parent 0f333d6
commit c92eafb
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 0 deletions.
diff --git a/tachyon/zk/base/halo2/halo2_random_field_generator.h b/tachyon/zk/base/halo2/halo2_random_field_generator.h
@@ -57,6 +57,7 @@ class Halo2RandomFieldGenerator : public RandomFieldGenerator<F> {
  return F::FromMontgomery(d2) + F::FromMontgomery(d3);
  }
 
+ // not owned
  crypto::XORShiftRNG* const generator_;
 };
 

diff --git a/tachyon/zk/expressions/evaluator/simple_evaluator.h b/tachyon/zk/expressions/evaluator/simple_evaluator.h
@@ -57,6 +57,7 @@ class SimpleEvaluator
  ~ScopedIdxIncrement() { ++evaluator->idx_; }
 
  private:
+ // not owned
  SimpleEvaluator* const evaluator;
  };
  ScopedIdxIncrement scoped_idx_increment(this);

diff --git a/tachyon/zk/plonk/circuit/floor_planner/simple_lookup_table_layouter.h b/tachyon/zk/plonk/circuit/floor_planner/simple_lookup_table_layouter.h
@@ -81,7 +81,9 @@ class SimpleLookupTableLayouter : public LookupTable<F>::Layouter {
  }
 
  private:
+ // not owned
  Assignment<F>* const assignment_;
+ // not owned
  const std::vector<LookupTableColumn>* const used_columns_;
  absl::flat_hash_map<LookupTableColumn, Value> values_;
 };

diff --git a/tachyon/zk/plonk/circuit/floor_planner/single_chip_layouter.h b/tachyon/zk/plonk/circuit/floor_planner/single_chip_layouter.h
@@ -105,6 +105,7 @@ class SingleChipLayouter : public Layouter<F> {
  }
 
  private:
+ // not owned
  SingleChipLayouter* const layouter_;
  const size_t region_index_;
  // Stores the constants to be assigned, and the cells to which they are
@@ -282,6 +283,7 @@ class SingleChipLayouter : public Layouter<F> {
  std::vector<FixedColumnKey> constants)
  : assignment_(assignment), constants_(std::move(constants)) {}
 
+ // not owned
  Assignment<F>* const assignment_;
  std::vector<FixedColumnKey> constants_;
  // Stores the starting row for each region.

diff --git a/tachyon/zk/plonk/circuit/lookup_table.h b/tachyon/zk/plonk/circuit/lookup_table.h
@@ -39,6 +39,7 @@ class LookupTable {
  explicit LookupTable(Layouter* layouter) : layouter_(layouter) {}
 
  private:
+ // not owned
  Layouter* const layouter_;
 };
 

diff --git a/tachyon/zk/plonk/circuit/namespaced_layouter.h b/tachyon/zk/plonk/circuit/namespaced_layouter.h
@@ -64,6 +64,7 @@ class NamespacedLayouter : public Layouter<F> {
  }
 
  private:
+ // not owned
  Layouter<F>* const layouter_;
 };
 

diff --git a/tachyon/zk/plonk/circuit/region.h b/tachyon/zk/plonk/circuit/region.h
@@ -144,6 +144,7 @@ class Region {
  }
 
  private:
+ // not owned
  Layouter* const layouter_;
 };
 

diff --git a/tachyon/zk/plonk/circuit/virtual_cells.h b/tachyon/zk/plonk/circuit/virtual_cells.h
@@ -90,6 +90,7 @@ class VirtualCells {
  }
 
  private:
+ // not owned
  ConstraintSystem<F>* const meta_;
  std::vector<Selector> queried_selectors_;
  std::vector<VirtualCell> queried_cells_;