-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change validator client subcommands #360
feat: change validator client subcommands #360
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
010f84e
to
ad0488b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we add delegate
for validator system v2 as well?
Since some operators may want to delegate KRO as well, not using for bond but just for increase the probability for being selected as priority validator.
I think it's ok without |
To delegate using UI, the operator should export and import the private key, so I thought it would be good if the operator can delegate KRO in the same environment that operating validator. But it's good to have for now. |
What you think the demand for this use case? If this demand is huge, adding this will be def right, but if it's not huge, i think there's some possibilities that it may confuse operators about what to use between depositKro and delegate in various situations. |
It make sense. Let's merge as is. |
a356eb5
to
0f0a9e6
Compare
c77accc
into
feat/implement-validator-system-v2
Description
Updated subcommands for the changed validator system v2.
Also found a duplicated check at
depositToRegister
function in AssetManager, so removed it.