feat(contracts): apply audit results (#373)

* feat(contracts): remove the comment that implies bond amount change

* feat(contracts): save deleted output and enhance check when dismiss challenge

* feat(contracts): restrict contract address cannot call `registerValidator`

* feat(contracts): remove meaningless unchecked block

* feat(contracts): add sanity checks for `BalancedWeightTree`

* chore(contracts): update bindings and snapshots

* feat: apply contract interface changes to client code

* feat(contracts): apply PR review

kroma-validator/challenger.go

@@ -734,7 +734,26 @@ func (c *Challenger) IsOutputFinalized(ctx context.Context, outputIndex *big.Int
 func (c *Challenger) GetChallenge(ctx context.Context, outputIndex *big.Int, challenger common.Address) (bindings.TypesChallenge, error) {
  cCtx, cCancel := context.WithTimeout(ctx, c.cfg.NetworkTimeout)
  defer cCancel()
- return c.colosseumContract.GetChallenge(optsutils.NewSimpleCallOpts(cCtx), outputIndex, challenger)
+
+ challenge, err := c.colosseumContract.Challenges(optsutils.NewSimpleCallOpts(cCtx), outputIndex, challenger)
+ if err != nil {
+ return bindings.TypesChallenge{}, fmt.Errorf("failed to fetch challenge data: %w", err)
+ }
+
+ segments, err := c.colosseumContract.GetSegments(optsutils.NewSimpleCallOpts(cCtx), outputIndex, challenger)
+ if err != nil {
+ return bindings.TypesChallenge{}, fmt.Errorf("failed to fetch challenge segments data: %w", err)
+ }
+
+ return bindings.TypesChallenge{
+ Turn: challenge.Turn,
+ TimeoutAt: challenge.TimeoutAt,
+ Asserter: challenge.Asserter,
+ Challenger: challenge.Challenger,
+ Segments: segments,
+ SegSize: challenge.SegSize,
+ SegStart: challenge.SegStart,
+ }, nil
 }
 
 func (c *Challenger) OutputAtBlockSafe(ctx context.Context, blockNumber uint64) (*eth.OutputResponse, error) {
@@ -863,7 +882,8 @@ func (c *Challenger) GetChallengeStatus(ctx context.Context, outputIndex *big.In
 func (c *Challenger) BuildSegments(ctx context.Context, turn uint8, segStart, segSize uint64) (*chal.Segments, error) {
  cCtx, cCancel := context.WithTimeout(ctx, c.cfg.NetworkTimeout)
  defer cCancel()
- sections, err := c.colosseumContract.GetSegmentsLength(optsutils.NewSimpleCallOpts(cCtx), turn)
+
+ sections, err := c.colosseumContract.SegmentsLengths(optsutils.NewSimpleCallOpts(cCtx), big.NewInt(int64(turn-1)))
  if err != nil {
  return nil, fmt.Errorf("unable to get segments length of turn %d: %w", turn, err)
  }

op-e2e/actions/l2_runtime.go

@@ -278,7 +278,7 @@ func (rt *Runtime) setupChallenge(challenger *L2Validator, version uint8) {
  require.Equal(rt.t, types.ReceiptStatusSuccessful, rt.receipt.Status, "failed to create challenge")
 
  // check challenge created
- challenge, err := rt.colosseumContract.GetChallenge(nil, rt.outputIndex, challenger.address)
+ challenge, err := rt.colosseumContract.Challenges(nil, rt.outputIndex, challenger.address)
  require.NoError(rt.t, err)
  require.NotNil(rt.t, challenge, "challenge not found")
 

op-e2e/system_test.go

@@ -1740,7 +1740,6 @@ func TestChallenge(t *testing.T) {
  return
  }
  }
-
  }
 }
 

packages/contracts/.storage-layout

@@ -13,6 +13,7 @@
 | segmentsLengths | mapping(uint256 => uint256) | 1 | 0 | 32 | contracts/L1/Colosseum.sol:Colosseum |
 | challenges | mapping(uint256 => mapping(address => struct Types.Challenge)) | 2 | 0 | 32 | contracts/L1/Colosseum.sol:Colosseum |
 | verifiedPublicInputs | mapping(bytes32 => bool) | 3 | 0 | 32 | contracts/L1/Colosseum.sol:Colosseum |
+| deletedOutputs | mapping(uint256 => struct Types.CheckpointOutput) | 4 | 0 | 32 | contracts/L1/Colosseum.sol:Colosseum |
 
 =======================
 ➡ contracts/L1/SecurityCouncil.sol:SecurityCouncil

packages/contracts/contracts/L1/AssetManager.sol

@@ -66,7 +66,7 @@ contract AssetManager is ISemver, IERC721Receiver, IAssetManager {
  uint128 public immutable MIN_DELEGATION_PERIOD;
 
  /**
- * @notice The amount to bond. Can be updated via upgrade.
+ * @notice The amount to bond.
  */
  uint128 public immutable BOND_AMOUNT;