Skip to content

Commit

Permalink
Use v0.9.0-20180826174721 in kristinalim fork of angular-foundation
Browse files Browse the repository at this point in the history
There is a bug in the handling of % values for the "top" CSS property of
the modals. See details here:

openfoodfoundation/angular-foundation#1

A PR to the original repository has also been submitted, but the project
doesn't seem to be active anymore:

yalabot/angular-foundation#319

And to another fork of the repository:

cwadrupldijjit/angular-foundation#1

The bug was causing the 10% "top" CSS property for the modal to be
treated as 10px.
  • Loading branch information
kristinalim committed Sep 3, 2018
1 parent 4bcafcd commit 9ff1d25
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion app/assets/javascripts/admin/all.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
//= require moment/nb.js
//= require moment/pt-br.js
//= require moment/sv.js
//= require ../shared/mm-foundation-tpls-0.8.0.min.js
//= require ../shared/mm-foundation-tpls-0.9.0-20180826174721.min.js
//= require angularjs-file-upload

//= require_tree .
2 changes: 1 addition & 1 deletion app/assets/javascripts/darkswarm/all.js.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#= require lodash.underscore.js
#= require angular-scroll.min.js
#= require angular-google-maps.min.js
#= require ../shared/mm-foundation-tpls-0.8.0.min.js
#= require ../shared/mm-foundation-tpls-0.9.0-20180826174721.min.js
#= require ../shared/ng-infinite-scroll.min.js
#= require ../shared/angular-local-storage.js
#= require ../shared/angular-slideables.js
Expand Down
10 changes: 0 additions & 10 deletions app/assets/javascripts/shared/mm-foundation-tpls-0.8.0.min.js

This file was deleted.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion spec/javascripts/application_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
//= require lodash.underscore.js
//= require angular-flash.min.js
//= require shared/ng-tags-input.min.js
//= require shared/mm-foundation-tpls-0.8.0.min.js
//= require shared/mm-foundation-tpls-0.9.0-20180826174721.min.js
//= require textAngular-rangy.min.js
//= require textAngular-sanitize.min.js
//= require textAngular.min.js
Expand Down

0 comments on commit 9ff1d25

Please sign in to comment.