Support windows #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tamago324 I left one comment on code. Please review it so we can wra0 up this support. |
|
Thank you for your comment. |
autoload/vim_dadbod_completion.vim
Outdated
| @@ -163,7 +163,8 @@ function! s:generate_query(db, query_key, ...) abort | |||
| if a:0 > 0 | |||
| let Query = Query(a:1) | |||
| endif | |||
| return printf('%s %s', base_query, Query) | |||
| " for PostgreSQL | |||
| return printf('%s %s', substitute(base_query, '"', '', 'g'), Query) | |||
There was a problem hiding this comment.
Why this has to be done? Isn't dadbod taking care of this?
There was a problem hiding this comment.
A string like the following was returned
psql -w --dbname "postgresql://postgres:[email protected]:5432/shop"
However, it was confirmed that it works normally even if you don't replace it with substitute().
Therefore, it is removed.
|
Thanks! |
|
Thank you so much for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kristijanhusak
Thank you for the great plugin ✨
It now works on Windows.
I've tested all three on Ubuntu and Windows.
However, the connection from Neovim on Windows to PostgreSQL could not be made because of these issue. Maybe it's just my environment.
I have only checked
omnifunc, should I also checkcoc.nvimanddeoplete.nvim?If I have to check, I will check.
Thank you!