-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webrtc merge #38
base: master
Are you sure you want to change the base?
Webrtc merge #38
Conversation
This reverts commit d570815.
…the bundle is slightly large.
…hang and break in-game connections.
Conflicts: cube2/game/setup_low.js cube2/js/game-setup.js cube2/src/web/Makefile
…if not supported.
…tc-support-merge Conflicts: cube2/src/web/Makefile
…tc-support Conflicts: cube2/js/game-setup.js cube2/src/web/Makefile
Conflicts: cube2/src/web/Makefile
Conflicts: cube2/src/web/Makefile
Great, thanks. Comments:
but then it hangs. I wonder if we don't just want to disable networking or something like that. |
Sorry to bump this, but why wasn't it merged? |
What was the hold up on this? Any chance @kripken or @modeswitch could fix the conflicts so it can be merged? |
I don't remember the history here, but webrtc support in emscripten itself has stagnated, the tests have been disabled. We need more help in that area. |
I believe we should switch to a more robust library like socket.io or engine.io with NodeJS for server side, like Inexor has done. |
@modeswitch @kripken I know this is necroposting, but I was curious about BananaBread as an example of networking on Emscripten. Are there more modern approaches? Or is this PR still a good piece of code to read and learn from? |
这里是龙嫣然的邮箱,感谢您的来信。
|
@VinnyVicious I actually am not sure what the best example of that is atm. Might want to open a discussion on the emscripten repo perhaps. |
@VinnyVicious This was intended to be a proof-of-concept. The underlying concepts should still work, even though the code is outdated. I won't guarantee that there isn't a more modern approach. |
Webrtc multiplayer support for BananaBread; Updated art assets and new levels from gk; Updated Makefile to avoid rebuilding packages all the time; Added
manifest.txt
andpublish.sh
to make packaging for upload to demo site easier