Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accuracy of CPU-bound benchmarks #1428

Closed
wants to merge 3 commits into from
Closed

Improve accuracy of CPU-bound benchmarks #1428

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd6bc7b
CPUBenchmark: run each iteration in new page
syduki Oct 16, 2023
7c02d46
Merge branch 'krausest:master' into master
syduki Oct 16, 2023
cfe12eb
Merge branch 'krausest:master' into master
syduki Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions webdriver-ts/src/forkedBenchmarkRunnerPuppeteer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,11 @@ async function runCPUBenchmark(framework: FrameworkData, benchmark: CPUBenchmark

console.log("benchmarking ", framework, benchmark.benchmarkInfo.id);
let browser : Browser = null;
let page : Page = null;
try {
browser = await startBrowser(benchmarkOptions);
page = await browser.newPage();
// if (config.LOG_DETAILS) {
page.on('console', (msg) => {
for (let i = 0; i < msg.args().length; ++i)
console.log(`BROWSER: ${msg.args()[i]}`);
});
// }
for (let i = 0; i <benchmarkOptions.batchSize; i++) {
const page = await browser.newPage();
page.on("console", (msg) => console.log('BROWSER:', ...msg.args()));
try {
await page.goto(`http://${benchmarkOptions.host}:${benchmarkOptions.port}/${framework.uri}/index.html`, {waitUntil: "networkidle0"});
} catch (ex) {
Expand Down Expand Up @@ -139,6 +133,9 @@ async function runCPUBenchmark(framework: FrameworkData, benchmark: CPUBenchmark
if (m2.Timestamp == m1.Timestamp) throw new Error("Page metrics timestamp didn't change");
results.push({total:result.duration, script: resultScript});
console.log(`duration for ${framework.name} and ${benchmark.benchmarkInfo.id}: ${JSON.stringify(result)}`);

await page.close();

if (result.duration < 0)
throw new Error(`duration ${result} < 0`);
}
Expand Down