Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validator throws 422 with message #191

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: validator throws 422 with message #191

wants to merge 4 commits into from

Conversation

thebrownfox
Copy link

@thebrownfox thebrownfox commented Apr 22, 2021

As mentioned in #168 the error response tell little to nothing.

There are 2 possible solutions:

  1. Patch it here and add Boom with right (I guess the right one is 422) statusCode
  2. Patch hapi. From the line I patched is the error thrown and processed here and follows here where it throws error without the details for what ever reason. Even if it will be done in hapi, we won't have statusCode: 422.

@dcharbonnier
Copy link
Contributor

do you think you could separate the style changes from this PR @thefoxie
even if they are justified, they need to be addressed on a different PR

@thebrownfox
Copy link
Author

@dcharbonnier
It was changed by eslint automatically. I could do that for sure.

@thebrownfox
Copy link
Author

@dcharbonnier like this?

@dcharbonnier
Copy link
Contributor

no @thefoxie as you can see, there is plenty of unrelated differences here https://github.com/krakenjs/hapi-openapi/pull/191/files

@tlivings
Copy link
Contributor

tlivings commented Jun 2, 2021

Waiting to remove style changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants