Remove the "layers" object in extra_config opentelemetry #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to override OTEL configuration for:
The "overrides" do not inherit parent configs, so if for example, you only specify this in a config for a backend:
The backend will not have static attributes for traces, the values for the traces will be the defaults (not the ones specified at the service level, inside layers), for metrics , the roundtrip , read_payload , and detailed_connection will be set to false.
The example provided, even it was actually performing a mix of attributes for the
proxy
and thebackend
layers, is not documented in KrakenD Community Edition, and does not match the format of the KrakenD Enterprise Edition.(Related PR: krakend/krakend-schema#52 )
A part from fixing the example, we want to maintain the ability to add static attributes at the endpoint and backend levels (but the config parsing must change to match the Enterprise edition).
This is intended for a 2.8 release (since the current behaviour is not documented, we can change it as is an "undocumented feature) .
Tested in Krakend CE
With config :
In the above config we disable the details in tracing for the
/user/{user}
backend request, so it won't have extra spans, and we add an attributea_git_key=a_git_value
, and we also add at the proxy levelprx_k=prx_val
, so, it works as expected :