Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global layer skip paths #19

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Global layer skip paths #19

merged 3 commits into from
Apr 25, 2024

Conversation

dhontecillas
Copy link
Contributor

Fixes #9
The SkipPaths are checked "verbatim" at the global http layer too, meaning, that no params are replaced or pattern matched before comparison.
Added a script to check that 404 does not happen anymore for skip_paths and that other 404 are reported as expected.

@kpacha kpacha merged commit 20e4cf8 into main Apr 25, 2024
3 checks passed
@kpacha kpacha deleted the global_layer_skip_paths branch April 25, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paths skipped still generate metric values in form of http_route="404 Not Found"
2 participants