Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using prefixes with 0xff as the last byte. #1125

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

tmccombs
Copy link
Contributor

This changes the logic for computing the range_end of a prefix so that
it works even if the prefix ends with one or more 0xff bytes

This changes the logic for computing the range_end of a prefix so that
it works even if the prefix ends with one or more 0xff bytes
@codecov-io
Copy link

codecov-io commented Apr 17, 2020

Codecov Report

Merging #1125 into master will decrease coverage by 0.20%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
- Coverage   94.02%   93.82%   -0.21%     
==========================================
  Files          10       10              
  Lines         787      826      +39     
==========================================
+ Hits          740      775      +35     
- Misses         47       51       +4     
Impacted Files Coverage Δ
etcd3/exceptions.py 88.88% <50.00%> (-11.12%) ⬇️
etcd3/locks.py 95.45% <94.28%> (-2.63%) ⬇️
etcd3/__init__.py 100.00% <100.00%> (ø)
etcd3/client.py 96.52% <100.00%> (+0.15%) ⬆️
etcd3/utils.py 100.00% <100.00%> (ø)
etcd3/watch.py 85.61% <0.00%> (-0.21%) ⬇️
etcd3/leases.py 100.00% <0.00%> (ø)
etcd3/members.py 81.25% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967cc5c...b432062. Read the comment docs.

@tmccombs
Copy link
Contributor Author

tmccombs commented Apr 18, 2020

The travis builds failed, but they are also failing on master. I haven't had much look getting the tests to run locally (I'm using python 3.8).

@tmccombs
Copy link
Contributor Author

I haven't had much look getting the tests to run locally

Well besides the problem with dependencies that only work on python2, there's also this that was causing me problems

@tmccombs tmccombs mentioned this pull request Apr 19, 2020
Copy link
Owner

@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Sorry for the delay in merging this, had to look at the CI and dep problems first

@kragniz kragniz merged commit 00b278e into kragniz:master Apr 27, 2020
@kragniz kragniz mentioned this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants