Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new thinker thread for teleports #514

Closed
wants to merge 1 commit into from

Conversation

MarkJeronimus
Copy link
Contributor

This fixes the extreme lag in Oversaturation when thousands of zombies try to teleport in, and the th_misc class thinker list is around 60000 elements long.

Bofu correctrly voices his concern about desyncs. I think, if the teleport destinations in the list can be guaranteed to be in the same order, there should be no desyncs.

This fixes the extreme lag in Oversaturation when thousands of zombies try to teleport in, and the th_misc class thinker list is around 60000 elements long.

Bofu correctrly voices his concern about desyncs. I think, if the teleport detinations in the list can be guaranteed to be in the same order, there should be no desyncs.
@kraflab
Copy link
Owner

kraflab commented Oct 4, 2024

I don't think this is a safe change - not because of the order of the teleporter list, but because they aren't in the old list anymore. Couldn't you potentially give the teleport destination monster properties with dehacked? You can also give it more physical properties in udmf that might matter. Rather than changing the core thinker list, I would suggest maintaining a separate teleporter list (probably in p_telept, exposed by stuff like P_RegisterTeleportDestination).

@MarkJeronimus
Copy link
Contributor Author

It doesn't desync on this monstrous demo, so I think we're safe.
https://www.doomworld.com/forum/post/2459281

@MarkJeronimus
Copy link
Contributor Author

MarkJeronimus commented Oct 5, 2024

Lol I didn't even see your reply even when I replied. Yeah, that could be a problem in maps that use more exotic stuff if there's a need for teleport destinations in the main list. You're free to rewrite this as you see fit. For Oversaturation, Vytaan is happy using it as we speak, even if it's a one-off build.

@kraflab
Copy link
Owner

kraflab commented Nov 3, 2024

Closing this PR but anyone who wants to take the alternate approach can create a new one in the future.

@kraflab kraflab closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants