Fix music not automatically playing when using shareware iwad. #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraflab
reviewed
Aug 23, 2024
musinfo is not tested or parsed for shareware iwads, but the musinfo list was not set appropriately.
PeterN
force-pushed
the
shareware-music
branch
from
6b2c1e1
to
58f10ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix music not automatically playing when using a shareware iwad.
musinfo is not tested or parsed for shareware iwads, but the musinfo list was not set appropriately.
This meant that when later trying to playing the music, an attempt is made to play an invalid music lump, which fails.