Fix z-fighting on bottom texture with skytexture #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the sector height is 0 and the floor is a skytexture, then in the bottom texture a sky hack would be drawn I cant seem to figure out why this if statement exists in the first place
|
@andrey-budko do you have any context on this code? |
|
Going to merge this and hope if there are any issues they get discovered in the beta 🤠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the sector height is 0 and the floor is a skytexture, then in the bottom texture a sky hack would be drawn
I cant seem to figure out why this if statement exists in the first place
This change prevents the sky from being drawn if a bottom texture is already there
So this shouldnt break anything