Color demo progress bar for Heretic and Hexen #477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, you could determine the lightest and darkest color in the current palette during init and use these. |
kraflab
reviewed
Mar 20, 2024
| @@ -756,7 +756,7 @@ int HU_DrawDemoProgress(int force) | |||
|
|
|||
| prev_len = len; | |||
|
|
|||
| V_FillRect(0, 0, SCREENHEIGHT - 4, len - 0, 4, 4); | |||
| V_FillRect(0, 0, SCREENHEIGHT - 4, len - 0, 4, (dsda_Flag(dsda_arg_heretic) || dsda_Flag(dsda_arg_hexen)) ? 255 : 4); | |||
There was a problem hiding this comment.
The shorthand for this is raven ? 255 : 4. But I would probably add a variable because I try to avoid having value branches like this all over the place.
Take a look at https://github.com/kraflab/dsda-doom/blob/master/prboom2/src/dsda/global.c#L127 and add something like g_demo_progress_color.
|
Thanks, I got busy and then forgot all about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Palette colour 4 in those games is near-black, while 255 is white.