add warning on failing nameservers

Signed-off-by: Kristoffer Dalby <[email protected]>
kradalby · Aug 16, 2024 · f10c6e2 · f10c6e2
1 parent fc7e63a
commit f10c6e2
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/hscontrol/types/config.go b/hscontrol/types/config.go
@@ -216,8 +216,6 @@ func LoadConfig(path string, isFile bool) error {
  }
  }
 
- // viper.ExperimentalBindStruct()
-
  envPrefix := "headscale"
  viper.SetEnvPrefix(envPrefix)
  viper.SetEnvKeyReplacer(strings.NewReplacer(".", "_"))
@@ -564,18 +562,27 @@ func (d *DNSConfig) GlobalResolvers() []*dnstype.Resolver {
  var resolvers []*dnstype.Resolver
 
  for _, nsStr := range d.Nameservers.Global {
+ warn := ""
  if _, err := netip.ParseAddr(nsStr); err == nil {
  resolvers = append(resolvers, &dnstype.Resolver{
  Addr: nsStr,
  })
 
  continue
+ } else {
+ warn = fmt.Sprintf("Invalid global nameserver %q. Parsing error: %s ignoring", nsStr, err)
  }
 
  if _, err := url.Parse(nsStr); err == nil {
  resolvers = append(resolvers, &dnstype.Resolver{
  Addr: nsStr,
  })
+ } else {
+ warn = fmt.Sprintf("Invalid global nameserver %q. Parsing error: %s ignoring", nsStr, err)
+ }
+
+ if warn != "" {
+ log.Warn().Msg(warn)
  }
  }
 
@@ -591,18 +598,27 @@ func (d *DNSConfig) SplitResolvers() map[string][]*dnstype.Resolver {
  for domain, nameservers := range d.Nameservers.Split {
  var resolvers []*dnstype.Resolver
  for _, nsStr := range nameservers {
+ warn := ""
  if _, err := netip.ParseAddr(nsStr); err == nil {
  resolvers = append(resolvers, &dnstype.Resolver{
  Addr: nsStr,
  })
 
  continue
+ } else {
+ warn = fmt.Sprintf("Invalid split dns nameserver %q. Parsing error: %s ignoring", nsStr, err)
  }
 
  if _, err := url.Parse(nsStr); err == nil {
  resolvers = append(resolvers, &dnstype.Resolver{
  Addr: nsStr,
  })
+ } else {
+ warn = fmt.Sprintf("Invalid split dns nameserver %q. Parsing error: %s ignoring", nsStr, err)
+ }
+
+ if warn != "" {
+ log.Warn().Msg(warn)
  }
  }
  routes[domain] = resolvers