empty string is always in string

Signed-off-by: Kristoffer Dalby <[email protected]>

hscontrol/types/config.go

@@ -755,7 +755,7 @@ func GetHeadscaleConfig() (*Config, error) {
  // - MagicDNS (BaseDomain) for users is on a *.ts.net domain per tailnet (e.g. tail-scale.ts.net)
  //
  // TODO(kradalby): remove dnsConfig.UserNameInMagicDNS check when removed.
- if !dnsConfig.UserNameInMagicDNS && strings.Contains(serverURL, dnsConfig.BaseDomain) {
+ if !dnsConfig.UserNameInMagicDNS && dnsConfig.BaseDomain != "" && strings.Contains(serverURL, dnsConfig.BaseDomain) {
  return nil, errors.New("server_url cannot contain the base_domain, this will cause the headscale server and embedded DERP to become unreachable from the Tailscale node.")
  }