Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 build and test #105

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Python 3.12 build and test #105

merged 2 commits into from
Apr 4, 2024

Conversation

kplindegaard
Copy link
Owner

@kplindegaard kplindegaard commented Mar 16, 2024

Formalizing Python 3.12 support: Updated actions and metainfo.

@kplindegaard kplindegaard marked this pull request as ready for review March 16, 2024 16:58
@kplindegaard kplindegaard mentioned this pull request Mar 16, 2024
@@ -67,6 +67,7 @@ def find_version(*file_paths):
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11"
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12"
],
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 30 in setup.cfg can also be removed since only py >=3.4 is supported: 'mock;python_version<"3.3"',

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ps. dropping support for python 3.4, 3.5 and 3.6 might also be a good idea since they're all EOL (even 3.7 is now).

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers. Can probably drop that entire test_deps block as we replaced nose with pytest during the transition to Github actions.

Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kplindegaard kplindegaard merged commit 6724759 into master Apr 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants