Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] should_grokfast condition #280

Merged
merged 5 commits into from
Oct 12, 2024
Merged

[Fix] should_grokfast condition #280

merged 5 commits into from
Oct 12, 2024

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Oct 12, 2024

Problem (Why?)

Fixes #279
Close #194, #278

Solution (What/How?)

  • only check grokfast, grokfast_lamb params when initializing state.

Other changes (bug fixes, small refactors)

N/A

Notes

N/A

@kozistr kozistr added bug Something isn't working documentation Improvements or additions to documentation dependencies Dependencies labels Oct 12, 2024
@kozistr kozistr self-assigned this Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (09a2b83) to head (600899f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #280   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines         7237      7237           
=========================================
  Hits          7237      7237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozistr kozistr merged commit 1687e37 into main Oct 12, 2024
4 checks passed
@kozistr kozistr deleted the fix/should-grokfast branch October 12, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Dependencies documentation Improvements or additions to documentation size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'grokfast_after_step' argument causes the optimizer to crash sophiah in https://github.com/booydar/LM-RMT
1 participant