Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add missing kwargs #271

Merged
merged 3 commits into from
Aug 15, 2024
Merged

[Fix] Add missing kwargs #271

merged 3 commits into from
Aug 15, 2024

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Aug 15, 2024

Problem (Why?)

fixes #270

Solution (What/How?)

  • add **kwargs to the parameter

Other changes (bug fixes, small refactors)

  • add tests for craete_optimizer

Notes

N/A

@kozistr kozistr added the bug Something isn't working label Aug 15, 2024
@kozistr kozistr self-assigned this Aug 15, 2024
@kozistr kozistr merged commit 5a65b51 into main Aug 15, 2024
2 checks passed
@kozistr kozistr deleted the fix/kwargs branch August 15, 2024 04:33
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a8eb19c) to head (480bd4c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #271   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           92        92           
  Lines         7008      7008           
=========================================
  Hits          7008      7008           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The create_optimizer() function fails when Lookahead arguments are provided
1 participant