Added the ability to layer a StateListDrawable over the bitmap. #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just use placeholder? |
|
I want the state list for the loaded bitmap.
|
|
Also, it seems like ion.iml isn't in the right .gitignore. I'm not sure if that needs to be checked into git, so if not, I can update this pull request to not track it anymore (same thing for .idea). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting sick of using FrameLayouts with my ImageViews and layering a View with a StateListDrawable background on top of it. I did basic testing on this using a GridView. Seems to work fine (a little slower than usual if you provide a resource because the StateListDrawable needs to be parsed), but it seemed like I had to scroll an ImageView off the screen and then back on again to get it to display if it was loaded from the cache. Let me know if you want me to do more intensive testing.