feat: PDF segmentation - viewer uses 4x less memory on mobile #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouassaba
changed the title
bouassaba
requested review from
dsonck92,
hoangna1204,
Mrkazik99 and
loboda4450
dsonck92
approved these changes
Aug 9, 2024
Mrkazik99
pushed a commit
that referenced
this pull request
Aug 14, 2024
* feat(conversion): add mobile optimization to PDF pipeline * feat: working implementation with API endpoints * fix(api): OpenAPI docs * chore: revert unnecessary changes * fix(api): OpenAPI docs * docs: update DEVELOPMENT.md * chore: rename to segmentation * chore: update OpenAPI docs * fix: revert DTO changes * chore: update OpenAPI docs * fix(migrations): file header * chore(ui): add PDFProps field * feat: use ImageMagick to generate PDF thumbnails as JPEG * chore: generate OpenAPI docs
loboda4450
pushed a commit
that referenced
this pull request
Sep 4, 2024
…298) * feat(ui)!: first snapshot of working admin panel BREAKING CHANGE: New client, additional option in fetcher, ui for new microservice * feat: add idp changes to this branch, user suspend system, migrations update * fix: add missing authorization check on thumbnail download endpoint (#248) * fix: param OpenAPI docs (#249) * fix(conversion): mosaic S3 key (#253) * refactor(api): stylecheck suggestions (#255) * feat: PDF segmentation - viewer uses 4x less memory on mobile (#254) * feat(conversion): add mobile optimization to PDF pipeline * feat: working implementation with API endpoints * fix(api): OpenAPI docs * chore: revert unnecessary changes * fix(api): OpenAPI docs * docs: update DEVELOPMENT.md * chore: rename to segmentation * chore: update OpenAPI docs * fix: revert DTO changes * chore: update OpenAPI docs * fix(migrations): file header * chore(ui): add PDFProps field * feat: use ImageMagick to generate PDF thumbnails as JPEG * chore: generate OpenAPI docs * chore: enrich S3Object with more metadata + dynamic params (#258) * chore: enrich S3Object * fix: router params * fix: router params * fix: error checking * feat: enrich snapshot.mosaic field * chore: improve S3Object data structure * chore: improve S3Object data structure - part 2 (#259) feat: further enrichment of snapshot.original field with more properties (see JSON below) feat: further enrichment of snapshot.preview field with more properties (see JSON below) feat: further enrichment of snapshot.segmentation field with more properties (see JSON below) feat: further enrichment of snapshot.mosaic field with more properties (see JSON below) refactor: clients on API microservice look the same like other microservices (preparing for deduplication) * fix: perform an apt-get update before installing packages (#260) To prevent using outdated links to debian packages that were last refreshed during the docker build, perform an apt-update at the start. * feat: reprocess endpoint (#262) * feat(api): endpoint to reprocess a file * refactor(api): no naked return * refactor(api): don't mark folders as rejected * fix: set snapshot.task_id to NULL when deleting a task * chore: format code * chore: fix linter error * feat(api): check task status on reprocess (#263) * fix(api): support mosaic without preview (#264) * feat: use bild (#268) * feat(mosaic): use bild * chore(conversion): format code * refactor(mosaic): delete not needed type conversion * feat(conversion): use bild * refactor(mosaic): remove more unnecessary type conversions * fix: hybrid integration of bild & ImageMagick (#269) * fix: hybrid integration of bild and ImageMagick * chore: format code * fix: add support for .tif extension * fix: various issues * fix: base mosaic on preview * fix(webdav): make MKCOL function as mkdir -p (#271) * refactor(ui): add missing permission functions (#261) * feat(conversion): automatically trigger mosaic (#276) * feat(conversion): automatically trigger mosaic * refactor(conversion): adjustments * refactor(conversion): no need for a separate function * fix(conversion): delete output files correctly * fixup! fix(conversion): delete output files correctly * fix(conversion): correctly handle forwarding in pipelines * feat: users management almost complete, getting data from admin microservice also works * feat: generic confirmation and rename modals for admin privileges management * feat(ui)!: first snapshot of working admin panel BREAKING CHANGE: New client, additional option in fetcher, ui for new microservice * feat: add idp changes to this branch, user suspend system, migrations update * feat: users management almost complete, getting data from admin microservice also works * feat: generic confirmation and rename modals for admin privileges management * feat: Rename states * feat: Detailed views for organizations and users * feat: final v1 of admin panel front and IdP * feat: Add version routers for each component and handle it properly on UI, Pagination option to disable rewind and jump to last buttons * fix: remove dev url from config * feat: Rename service to console * feat: Initial user will be admin, Make console panel searchable * fix: Fix issues mentioned by Anass * fix: fix linter issue * fix: fix linter issue v2 * fix: fix linter issue v3 --------- Co-authored-by: Anass Bouassaba <[email protected]> Co-authored-by: Daniël Sonck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2/files/{id}/segmentation/pages/1.pdfv2/files/{id}/segmentation/thumbnails/1.pngCloses #247