-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite WebDAV in Go for optimized memory usage #129
Conversation
Nice progress already, probably you want to convert this to draft for the time being to mark it a little more explicit. You definitely went the route I also had in mind when seeing the WebDav server was written in TypeScript/JavaScript. I still have hopes that it can be memory efficient even on that engine, but in practice I haven't seen it yet. So a change to Go seems logical. |
@dsonck92 Thanks! I will convert it to draft ;) |
@@ -1,3 +1,15 @@ | |||
PORT=8082 | |||
|
|||
# Security | |||
SECURITY_API_KEY="7znl9Zd8F!4lRZA43lEQb757mCy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take it as a note:
I'd rethink the idea of passing the api keys, jwt etc. as a envs. It is a good practice to roll them from time to time, but having it that way will make everybody forget about it. I will create a issue for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, thanks!
@bouassaba do you want to add the linters before or after this PR? You can probably copy it over from the existing files, and enable as many linters as possible to see how they like the code. EDIT: WSL is also going to have a field day here, and probably funlen. But I don't really see an easy way to, improve that situation (especially funlen). Well, other than doing potentially splitting up functions into a common "check preconditions". |
@dsonck92 sure I will copy them afterwards. |
Alright, then I will have a look at the changes if there's anything strange going on, and ignore the formatting for now. |
No description provided.