Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML-CSS-Popup #743

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

HTML-CSS-Popup #743

wants to merge 13 commits into from

Conversation

Cashass
Copy link

@Cashass Cashass commented Oct 7, 2022

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

Cashass and others added 8 commits October 3, 2022 19:55
amended document
amended document
made changes in connection with the addition li to html
Add (.sub__check-input:checked display: none; )
Added # in Новини, no matter how the page reloads.
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes.

In addition to the bot's suggestions above, please post a link to the app demo in Students' chat, collect feedback and fix bugs if any based on that. When user tests are done post here a comment on that.

Universal recommendations:

  • Make sure your code follows General Requirements
  • Use common sense or seek for an advice whenever requirements look ambiguous or unclear.
  • Pay more attention to code style - descriptive variable names, indentations, empty spaces, etc. Code should look good :)

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

@Cashass
Copy link
Author

Cashass commented Oct 10, 2022

Hi.
I finished the self-check and corrected the code accordingly, my code was reviewed in the FE Questionarium, now I am adding an adaptive.

Made changes to improve the adaptive
@Cashass
Copy link
Author

Cashass commented Nov 12, 2022

Добрий день.
Вибачаюсь, що довго не відповідав, були проблеми зі здоров'ям.
Зараз покращив адаптив.

Hid scroll
Fixed jumps layout when hovering over links
Copy link
Contributor

@OlexiyDobroskok OlexiyDobroskok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. It remains to make minor changes to bring the work to the ideal)

<a href="#" class="popup__link">
<img
class="popup-img"
src="icon/Безпека.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use English for filenames.

Comment on lines 49 to 54
<img
class="popup-img"
src="icon/Календар.png"
alt="Календар"
/>Календар</a
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read how and when to populate alt attribute value 6 simple rules for good alt-text

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost don’t understand, it says what not to write near decorative icons, and the text should be meaningful. Thank you.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove the entire description, leave only an empty alt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make an alt description if the picture is relevant to the content. For decorative images, use alt, which is equal to an empty string

Vidaliv alt
@Cashass
Copy link
Author

Cashass commented Nov 13, 2022

Vіdaliv described alt

</li>
<li class="header__list">
<a href="#" class="header__link">
<img class="Фото користувача" src="icon/avatar.png" alt="Аватар" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What means class="Фото користувача" ? =)
Do not write alt if the picture does not have a special meaning - for example avatars in the profile.
Where alt is inappropriate, use alt, which is equal to the empty string. alt=''

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I clarify? I can leave the description of the "menu" and "Повідомлення" icons. They carry meaning.

Comment on lines 150 to 155
<img
class="sub__popup-img"
src="icon/Месенджер.png"
alt
/>Месенджер</a
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt must be equal to the empty string.
alt=''

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected. Changed file names to English. Add alt="". May I clarify? Can I leave a description of the "menu" and "View" icons? They carry meaning.

Copy link
Contributor

@OlexiyDobroskok OlexiyDobroskok Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I leave a description of the "menu" and "View" icons? They carry meaning.

Yes, you can.
If there is no text label on the menu button, you need to add alt-text. You can also describe its functionality in the code itself, like aria-label

File names changed to English. add alt=""
@OlexiyDobroskok
Copy link
Contributor

I consider the task completed and you can move on. Feel free to ask questions in the student chat and don't stop on follow-up tasks if the work isn't reviewed. Good Luck!

@Cashass
Copy link
Author

Cashass commented Nov 15, 2022

Дякую.

@stale
Copy link

stale bot commented May 15, 2023

This issue has been automatically marked as stale because there were no activity during last 14 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

А. Чому так?
Найбільш розповсюджена причина: Студент не реагує на коментарі змінами коду і не задає запитань через брак часу або зміну життєвих пріоритетів. Покинуті піари відволікають менторів. Коли у студента з'явиться час, він/вона зможе перевідкрити той самий піар і продовжити роботу.

Б. Що робити, якщо в піарі нема оновлень, оскільки не зрозуміло, що треба зробити?
Варіант 1. Задати питання в самому PR.
Варіант 2. Задати питання в студентському чаті.

В. А якщо я все зробив(ла) і це ментор не рев'юває мої зміни?

  1. Переконайся, що ти відреагував(ла) на всі коментарі або кодом, або запитаннями, або відповідями. Напиши в PR і в чаті, що чесно вважаєш, що все зроблено і попроси повторне рев'ю. Якщо щось не зрозуміло, задай запитання.
  2. Реагуй на коментарі як менторів, так і інших учасників, включаючи ботів.
  3. Не ігноруй прохання типу * "Let's do some self-checks ..." * "Go through the checklist below..." * "mark fulfilled requirements..." * "if you would silently ignore this recommendation, a mentor may think that you are still working on fixes"
    навіть якщо вони написані ботом. Боти помічники і ментори покладаються на те, що прохання і пропозиції бота дотримуються.
    Не лінись піти по лінках в коментарях, погуглити термінологію та скористатись Google Translate.
  4. Можливо, у менторів склалися інші пріоритети через роботу, сімейні обставини і т.п. В такому разі, якщо ти зробив(ла) рекомендоване вище, то волай в чаті, що PR позначений stale, наче, все зроблено, а ментори чомусь не реагують - рятуйте!

Г. Хіба недостатньо того, що я додав(ла) коміт із змінами?
Часто буває так, що бачиш новий коміт, ідеш перевіряти, змін багато, доводиться перечитувати весь код. А потім з'ясовується, що одна невеличка зміна "відкладена на потім" чи з'являється ще один коміт і знов треба перечитувати все. Любіть нас, спілкуйтеся з нами - і ми відповімо повною взаємністю.

Традиційна пропозиція: задай питання по вищенаписаному в студентському чаті.

@stale stale bot added the 💤 Stale label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants