Don't run javaaddpath gratuitously #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javaaddpath has the side effect of erasing all global and Java variables. Should need to do it over and over!
kotowicz
added a commit
that referenced
this pull request
Oct 24, 2013
thanks chinasaur. I assume your patch fixes the clearing of globals?
ghost
assigned 
|
@chinasaur: the code introduces some new problems, so I'll have to revisit the entire globals problem again. I'd be happy if you could provide any feedback: #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
javaaddpath has the side effect of erasing all global variables. Shouldn't need to do it over and over!