Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use VOLUME #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not use VOLUME #6

wants to merge 1 commit into from

Conversation

Vanuan
Copy link

@Vanuan Vanuan commented Jun 30, 2016

If you specify a volume in Dockerfile, it would be impossible to remove/override it using command line options.
Moreover, it would leave dangling volumes for inexperienced users and users of docker-compose.
In docker-compose, you wouldn't be able to specify mounted volume.
Please let the user specify the volume location.

If you specify a volume in Dockerfile, it would be impossible to remove/override it using options.
Moreover, it would leave dangling volumes for inexperienced users and users of docker-compose.
In docker-compose, you wouldn't be able to specify mounted volume.
Please let the user specify the volume location.
@lgelfan
Copy link

lgelfan commented Jul 19, 2016

If you use your own volume attribute during run or similar, it will use that and not the one in the Dockerfile. At least the one in the Dockerfile keeps it out of the container if someone doesn't specify a volume. I agree that it could/will lead to orphaned volumes but that seems like general issue not specific to this.

@Vanuan
Copy link
Author

Vanuan commented Jul 19, 2016

If you use your own volume attribute during run or similar, it will use that and not the one in the Dockerfile.

If it should, then it is a bug in docker-compose, because for me it doesn't work. There are dangling volumes all over the place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants