Merge pull request #59 from miguelaferreira/address-linting-warnings

Address linting warnings

dockerhub/Dockerfile

@@ -20,4 +20,4 @@ RUN wget https://get.helm.sh/helm-v${HELM_VERSION}-linux-amd64.tar.gz -O - | tar
 RUN chmod +x /usr/local/bin/helm
 
 COPY entrypoint.sh /entrypoint.sh
-ENTRYPOINT ["/entrypoint.sh"]:
+ENTRYPOINT ["/entrypoint.sh"]

dockerhub/entrypoint.sh

@@ -1,24 +1,28 @@
-#!/bin/sh
+#!/bin/bash
 
 set -e
 
-echo ${KUBE_CONFIG_DATA} | base64 -d > kubeconfig
+echo "${KUBE_CONFIG_DATA}" | base64 -d > kubeconfig
 export KUBECONFIG="${PWD}/kubeconfig"
-chmod 600 ${PWD}/kubeconfig
+chmod 600 "${PWD}/kubeconfig"
 
 if [[ -n "${INPUT_PLUGINS// /}" ]]
 then
-    plugins=$(echo $INPUT_PLUGINS | tr ",")
+    plugins="$(echo "${INPUT_PLUGINS}" | tr ",")"
 
-    for plugin in $plugins
+    for plugin in ${plugins}
     do
-        echo "installing helm plugin: [$plugin]"
-        helm plugin install $plugin
+        echo "installing helm plugin: [${plugin}]"
+        helm plugin install "${plugin}"
     done
 fi
 
 echo "running entrypoint command(s)"
 
-response=$(sh -c " $INPUT_COMMAND")
+response=$(bash -c "${INPUT_COMMAND}")
 
-echo "response=$response" >> $GITHUB_OUTPUT
+{
+  echo "response<<EOF";
+  echo "$response";
+  echo "EOF";
+} >> "${GITHUB_OUTPUT}"