refactor: do not constrain PacketIdBindings with ContainsDistinctT

See #40 (comment) for why we are doing this.
kory33 · Mar 6, 2022 · 72c53bb · 72c53bb
1 parent fd6b037
commit 72c53bb
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/.../src/main/scala/io/github/kory33/s2mctest/core/connection/protocol/PacketIdBindings.scala b/.../src/main/scala/io/github/kory33/s2mctest/core/connection/protocol/PacketIdBindings.scala
@@ -14,12 +14,12 @@ type CodecBinding[A] = (PacketId, ByteCodec[A])
 /**
  * An object that associates packet IDs with corresponding datatypes' codec.
  *
- * [[PacketTup]] is a tuple of packets with no duplicates, used in associating codecs. It is
- * also required that [[bindings]] should not contain two entries with the same packet ID.
+ * [[PacketTup]] is a tuple of packets with no duplicates, and is used in associating codecs. It
+ * is also required that [[bindings]] should not contain two entries with the same packet ID.
  */
 class PacketIdBindings[PacketTup <: Tuple](
   bindings: Tuple.Map[PacketTup, CodecBinding]
-)(using Require[ContainsDistinctT[PacketTup]]) {
+) {
 
   require(
     {
@@ -65,12 +65,8 @@ class PacketIdBindings[PacketTup <: Tuple](
 }
 
 object PacketIdBindings {
-  def apply[BindingsTup <: Tuple](
-    bindingsTup: BindingsTup
-  )(
+  def apply[BindingsTup <: Tuple](bindingsTup: BindingsTup)(
     using ev: Tuple.IsMappedBy[CodecBinding][BindingsTup]
-  )(
-    using Require[ContainsDistinctT[Tuple.InverseMap[BindingsTup, CodecBinding]]]
   ): PacketIdBindings[Tuple.InverseMap[BindingsTup, CodecBinding]] = {
     new PacketIdBindings[InverseMap[BindingsTup, CodecBinding]](
       ev(bindingsTup)