Request reviewers automatically #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korthout
force-pushed
the
korthout-2-reviewers
branch
from
7c9b18e
to
b405c7e
Compare
|
Test in automation lab successful source PR: https://github.com/zeebe-io/automation-lab/pull/47 |
|
@pihme Please have a look |
pihme
approved these changes
Nov 30, 2020
|
I think we should also start implementing tests going forward. |
|
@pihme I agree we should add tests. Should we do that before merging this or do you think it's out of scope? After applying the review hints I now still need to do an additional manual test to see that it still works. 😞 EDIT: I've also applied your hints. Please have a look 👍 |
|
@korthout Let's add the tests for the next change. |
This was referenced May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the action request reviewers for the newly created backport PRs. For this it uses the same reviewers as the PR that is backported.
closes #2