Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not wrap subqueries of combined queries, fixes #328. #329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not wrap subqueries of combined queries, fixes #328. #329

wants to merge 1 commit into from

Conversation

juhovh
Copy link
Contributor

@juhovh juhovh commented Nov 1, 2015

More information in the related issue.

@juhovh
Copy link
Contributor Author

juhovh commented Nov 10, 2015

Any comments or suggestions on how to improve this in case the proposed fix is not ok?

@immoh
Copy link
Member

immoh commented Nov 10, 2015

Apologies for not responding earlier.

I don't like duplicating code, and I don't like the fallback if we don't know that it is needed.

I suppose it is possible to have (raw "select * from foo") as a subquery, but I'm fine with supporting only subselect there. One possible solution would be to extract subselect handling without wrapping to a separate function and call that function from both map-val and sql-combination-query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juhovh @immoh