fix a bunch of -Wall warnings, part 3 #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-pierre
force-pushed
the
pr/fix_-Wall_warnings_part3
branch
from
bf7bab9
to
82908f5
Compare
Frenzie
reviewed
Aug 1, 2024
poire-z
reviewed
Aug 1, 2024
|
May be the lvxml: fix compiler warning [-Wunused-private-field] commit deserve having as the commit message what you explained to me in the other PR ? |
benoit-pierre
force-pushed
the
pr/fix_-Wall_warnings_part3
branch
from
82908f5
to
21175af
Compare
The code `enum { } formatFlags_t` was actually declaring a private
(unused) field, not a type: make it a proper type declaration and
use it where applicable (e.g. the `formatFlags` private field).
If `PDBHdr->read` succeed, the structure is initialized anyway.
benoit-pierre
force-pushed
the
pr/fix_-Wall_warnings_part3
branch
from
21175af
to
4b300d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is