Testing #582
Closed
Testing #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` template-id not allowed for constructor/destructor in C++20 ```
About (possibly) unused functions.
…ings The function actually parses an unsigned integer.
``` warning: Rethrowing current exception with 'throw;', it seems there is no current exception to rethrow. If there is no current exception this calls std::terminate(). ```
Comment out unused & problematic code:
```
crengine/include/lvref.h:395:16: warning: Reference to temporary returned. [returnTempReference]
return LVRef(NULL);
^
crengine/include/lvref.h:396:15: warning: Reference to temporary returned. [returnTempReference]
return LVRef( new T( *_ptr ) );
```
``` warning: Value stored to 'pDiag' is never read [clang-analyzer-deadcode.DeadStores] ```
``` warning: Rethrowing current exception with 'throw;', it seems there is no current exception to rethrow. If there is no current exception this calls std::terminate(). ```
- fix cppcheck & clang-tidy configurations to avoid parsing, processing, and/or spurious errors. - parallelize all checks to speed up linting (which is much slower now that cppcheck & clang-tidy can actually do their jobs). - always lint all files (we care about), instead of trying to determine what changed: even if a source file, say `crengine/src/lvtinydom.cpp`, was not changed in a PR, some change to included headers may break something that could be detected by one of the checks. - plus colors, groups and error annotations on Github Actions!
- cppcheck does not like it - it does not match our default configuration on koreader anyway (where we use lunasvg)
To make cppcheck happy.
Simplify the code and make cppcheck happy.
- it's already stubbed anyway, stub it more! - I have seen at least one crash with the default stub (clang emulator) - cppcheck is not happy about it
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwaway PR to see how things look with #579 and #580, plus a few additional tweaks to try to keep linting errors/warnings down.
This change is