Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to codegen.kt #965

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Switch to codegen.kt #965

wants to merge 6 commits into from

Conversation

DRSchlaubi
Copy link
Member

No description provided.

@DRSchlaubi
Copy link
Member Author

I think codegen kt doesn't run on jdk 8

buildSrc/src/main/kotlin/Projects.kt Outdated Show resolved Hide resolved
@@ -1,16 +1,24 @@
@file:OptIn(ExperimentalContracts::class, DelicateKotlinPoetApi::class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't like the opt-ins here, why not keep the old approach of using strings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this one is actually type-safe and I like it

ksp-processors/src/main/kotlin/KSPUtils.kt Outdated Show resolved Hide resolved
ksp-processors/src/main/kotlin/KotlinPoetDsl.kt Outdated Show resolved Hide resolved
@lukellmann
Copy link
Member

I think codegen kt doesn't run on jdk 8

the build failure looks more like a dependency resolution issue

@DRSchlaubi
Copy link
Member Author

Yeah because codegen.kt defines a jdk dependency in the Gradle meta

@DRSchlaubi
Copy link
Member Author

Since the CI now uses Java 21, this should work again

# Conflicts:
#	gradle/libs.versions.toml
#	ksp-processors/build.gradle.kts
#	ksp-processors/src/main/kotlin/KSPUtils.kt
#	ksp-processors/src/main/kotlin/generation/GenerationProcessor.kt
#	ksp-processors/src/main/kotlin/generation/bitflags/Builder.kt
#	ksp-processors/src/main/kotlin/generation/bitflags/ContainsPlusMinusCopy.kt
#	ksp-processors/src/main/kotlin/generation/bitflags/Serializer.kt
#	ksp-processors/src/main/kotlin/generation/kordenum/KordEnumGeneration.kt
#	ksp-processors/src/main/kotlin/generation/shared/EqualsHashCodeToString.kt
#	ksp-processors/src/main/kotlin/generation/shared/SharedContent.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants