-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spa): add deployments #967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libs/spa/view/dashboard/src/lib/dashboard.component.ts # package-lock.json # package.json
It is not possible to override standalone components. Thus, leaving us with the only possibility of mocking everything the dashboard component provides (which is quite a lot)
…loyment-frontend # Conflicts: # libs/shared/model/src/lib/gql.model.ts
timonmasberg
force-pushed
the
feat/deployment-frontend
branch
from
July 20, 2024 19:51
89c0466
to
f851fe0
Compare
…loyment-frontend # Conflicts: # package-lock.json
…loyment-frontend # Conflicts: # package-lock.json
Quality Gate failedFailed conditions |
# Conflicts: # package-lock.json
timonmasberg
force-pushed
the
feat/deployment-frontend
branch
2 times, most recently
from
September 20, 2024 07:59
d8e110c
to
86b1c88
Compare
Signed-off-by: Timon Masberg <[email protected]> # Conflicts: # package-lock.json
timonmasberg
force-pushed
the
feat/deployment-frontend
branch
from
September 20, 2024 09:13
86b1c88
to
2bcb12e
Compare
Signed-off-by: Timon Masberg <[email protected]>
Signed-off-by: Timon Masberg <[email protected]>
timonmasberg
force-pushed
the
feat/deployment-frontend
branch
from
September 20, 2024 10:01
b347823
to
524319b
Compare
Quality Gate failedFailed conditions |
timonmasberg
force-pushed
the
feat/deployment-frontend
branch
2 times, most recently
from
December 29, 2024 18:40
f6d4154
to
54701f3
Compare
JSPRH
previously approved these changes
Dec 29, 2024
…loyment-frontend # Conflicts: # package-lock.json
timonmasberg
force-pushed
the
feat/deployment-frontend
branch
from
December 29, 2024 23:26
54701f3
to
1b1163f
Compare
Quality Gate failedFailed conditions |
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
JSPRH
added a commit
that referenced
this pull request
Dec 30, 2024
Signed-off-by: Timon Masberg <[email protected]> Co-authored-by: Jasper Herzberg <[email protected]>
JSPRH
added a commit
that referenced
this pull request
Dec 30, 2024
Signed-off-by: Timon Masberg <[email protected]> Co-authored-by: Jasper Herzberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces the deployments' frontend with the dashboard view and a modal to sign in, update and sign off rescue stations. Each component has a test which sometimes rudimentary tests some features, but mainly is just a bootstrap with the necessary.
Also there is a change to the api, where the update mutation of a rescue station allows for optional protocol data (same flow as we currently have in the legacy application)
Checklist:
the Conventional Commits specification.
Coverage > 80% and not less than the current coverage of the main branch.
main
into your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations
).reset.d.ts
in thetsconfig.lib.json
.eslintrc.json
with.eslintrc.angular.json