Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spa): add deployments #967

Merged
merged 44 commits into from
Dec 29, 2024
Merged

feat(spa): add deployments #967

merged 44 commits into from
Dec 29, 2024

Conversation

timonmasberg
Copy link
Member

@timonmasberg timonmasberg commented Jul 12, 2024

Description

This introduces the deployments' frontend with the dashboard view and a modal to sign in, update and sign off rescue stations. Each component has a test which sometimes rudimentary tests some features, but mainly is just a bootstrap with the necessary.

Also there is a change to the api, where the update mutation of a rescue station allows for optional protocol data (same flow as we currently have in the legacy application)

Checklist:

  • The title of this PR and the commit history is conform with
    the Conventional Commits specification.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings, SonarCloud reports no Vulnerabilities, Bugs or Code Smells.
  • I have added tests (unit and E2E if user-facing) that prove my fix is effective or that my feature works,
    Coverage > 80% and not less than the current coverage of the main branch.
  • The PR branch is up-to-date with the base branch. In case you merged main into your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).
  • I have included the reset.d.ts in the tsconfig.lib.json
  • I have extended the .eslintrc.json with .eslintrc.angular.json

@timonmasberg timonmasberg self-assigned this Jul 12, 2024
# Conflicts:
#	libs/spa/view/dashboard/src/lib/dashboard.component.ts
#	package-lock.json
#	package.json
It is not possible to override standalone components. Thus, leaving us with the only possibility of mocking everything the dashboard component provides (which is quite a lot)
…loyment-frontend

# Conflicts:
#	libs/shared/model/src/lib/gql.model.ts
@timonmasberg timonmasberg marked this pull request as ready for review July 12, 2024 21:07
@timonmasberg timonmasberg requested a review from JSPRH July 12, 2024 21:07
@timonmasberg timonmasberg force-pushed the feat/deployment-frontend branch from 89c0466 to f851fe0 Compare July 20, 2024 19:51
…loyment-frontend

# Conflicts:
#	package-lock.json
…loyment-frontend

# Conflicts:
#	package-lock.json
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
73.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@timonmasberg timonmasberg force-pushed the feat/deployment-frontend branch 2 times, most recently from d8e110c to 86b1c88 Compare September 20, 2024 07:59
Signed-off-by: Timon Masberg <[email protected]>

# Conflicts:
#	package-lock.json
@timonmasberg timonmasberg force-pushed the feat/deployment-frontend branch from 86b1c88 to 2bcb12e Compare September 20, 2024 09:13
@timonmasberg timonmasberg force-pushed the feat/deployment-frontend branch from b347823 to 524319b Compare September 20, 2024 10:01
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
77.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@timonmasberg timonmasberg force-pushed the feat/deployment-frontend branch 2 times, most recently from f6d4154 to 54701f3 Compare December 29, 2024 18:40
JSPRH
JSPRH previously approved these changes Dec 29, 2024
…loyment-frontend

# Conflicts:
#	package-lock.json
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@timonmasberg timonmasberg merged commit 0ddc556 into main Dec 29, 2024
3 of 5 checks passed
@timonmasberg timonmasberg deleted the feat/deployment-frontend branch December 29, 2024 23:54
@timonmasberg
Copy link
Member Author

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

JSPRH added a commit that referenced this pull request Dec 30, 2024
Signed-off-by: Timon Masberg <[email protected]>
Co-authored-by: Jasper Herzberg <[email protected]>
JSPRH added a commit that referenced this pull request Dec 30, 2024
Signed-off-by: Timon Masberg <[email protected]>
Co-authored-by: Jasper Herzberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants