chore(spa): make csp headers optional in docker image #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonmasberg
changed the title
|
JSPRH
approved these changes
Mar 12, 2024
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the CSP configurations are hard-coded into the nginx config of the spa docker image, which also consists of the reverse proxy. As we need to add some sources, such as sentry, aadb2c and so on, which are specific to our instance, it would be a better approach to loosen the configuration to the minimum and offer an approach where the config can be adjusted to the instance's needs. Thus, this PR removes the CSP and compression config. A dedicated PR will cover the necessary changes of the infrastructure in our infra repo.