Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get container logs on console in e2es #685

Merged
merged 7 commits into from
Feb 22, 2024
Merged

fix: get container logs on console in e2es #685

merged 7 commits into from
Feb 22, 2024

Conversation

JSPRH
Copy link
Contributor

@JSPRH JSPRH commented Feb 16, 2024

Description

Provide the container logs to the console for failed e2e tests.

See this GH Action run for the output of a failed run.

Checklist:

  • The title of this PR and the commit history is conform with
    the Conventional Commits specification.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings, SonarCloud reports no Vulnerabilities, Bugs or Code Smells.
  • I have added tests (unit and E2E if user-facing) that prove my fix is effective or that my feature works,
    Coverage > 80% and not less than the current coverage of the main branch.
  • The PR branch is up-to-date with the base branch. In case you merged main into your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).

@JSPRH JSPRH force-pushed the fix/verbose-ci-e2e branch 2 times, most recently from 38c0870 to 122fa39 Compare February 21, 2024 06:43
@JSPRH JSPRH force-pushed the fix/verbose-ci-e2e branch from 9151089 to 2fc0f56 Compare February 22, 2024 05:48
@timonmasberg
Copy link
Member

very good changes

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JSPRH JSPRH merged commit e78142b into main Feb 22, 2024
5 checks passed
@JSPRH JSPRH deleted the fix/verbose-ci-e2e branch February 22, 2024 09:47
@timonmasberg
Copy link
Member

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants