Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use non-root user for API container #651

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

JSPRH
Copy link
Contributor

@JSPRH JSPRH commented Feb 1, 2024

Description

Use a non-root user for the API container for security purposes.

Checklist:

  • The title of this PR and the commit history is conform with
    the Conventional Commits specification.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings, SonarCloud reports no Vulnerabilities, Bugs or Code Smells.
  • I have added tests (unit and E2E if user-facing) that prove my fix is effective or that my feature works,
    Coverage > 80% and not less than the current coverage of the main branch.
  • The PR branch is up-to-date with the base branch. In case you merged main into your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).

@JSPRH JSPRH force-pushed the build-use-non-root-container-for-api branch from 61696a5 to 2dface0 Compare February 1, 2024 09:16
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JSPRH JSPRH requested a review from timonmasberg February 1, 2024 09:50
@JSPRH JSPRH merged commit beb0d5b into main Feb 1, 2024
11 checks passed
@JSPRH JSPRH deleted the build-use-non-root-container-for-api branch February 1, 2024 09:54
@timonmasberg
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants