feat(api): jwt verification #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonmasberg
force-pushed
the
feat/user-auth
branch
from
3d09f05 to
9129569
Compare
timonmasberg
force-pushed
the
feat/user-auth
branch
from
9129569 to
a83e5cd
Compare
|
Kudos, SonarCloud Quality Gate passed! |
# Conflicts: # package-lock.json # package.json
timonmasberg
force-pushed
the
feat/user-auth
branch
from
e204e7e to
f21fa1e
Compare
# Conflicts: # package-lock.json
timonmasberg
force-pushed
the
feat/user-auth
branch
from
f21fa1e to
4ee954b
Compare
|
timonmasberg
force-pushed
the
feat/user-auth
branch
from
29d897a to
d5d37cc
Compare
# Conflicts: # .github/actions/build-and-deploy-api/action.yml # .github/workflows/next-deployment.yml # apps/api/.env.template # apps/api/src/app/app.module.ts # package-lock.json
timonmasberg
force-pushed
the
feat/user-auth
branch
from
d5d37cc to
0b1f72d
Compare
timonmasberg
force-pushed
the
main
branch
2 times, most recently
from
9b697ff to
99a715d
Compare
# Conflicts: # libs/api/auth/src/lib/interceptors/auth.interceptor.spec.ts # package-lock.json
JSPRH
reviewed
Feb 13, 2024
libs/api/auth/src/lib/auth-strategies/verify-aadb2c-jwt.strategy.ts
Outdated
Show resolved
Hide resolved
libs/api/auth/src/lib/auth-strategies/verify-aadb2c-jwt.strategy.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # package-lock.json
timonmasberg
force-pushed
the
feat/user-auth
branch
from
421f13d to
0e73192
Compare
|
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we have to move away from Azure Web Apps, and cannot rely on the OAuth Proxy provided by it, we need to verify the token ourselves. This PR introduces an auth strategy that verifies the JWT against keys from AADB2C and decodes into an
AuthUser. The current strategy is now the dev strategy, not verifying the token, but only decoding it. Whenever we move completely to the on-prem system, we have to set the strategy toaadb2cto run the JWT verify strategy.Checklist:
the Conventional Commits specification.
Coverage > 80% and not less than the current coverage of the main branch.
maininto your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).