Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add warnings and weather module #296

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

timonmasberg
Copy link
Member

@timonmasberg timonmasberg commented Jul 24, 2023

Description

This adds our first location intelligence modules, weather, and warnings. For weather, we use Azure Maps to receive the current weather condition of a location and also daily and hourly forecasts. Warnings will be fetched from NINA and stored in the DB to get the delta and populate new warnings over GraphQL Subscriptions.

Checklist:

  • The title of this PR and the commit history is conform with
    the Conventional Commits specification.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings, SonarCloud reports no Vulnerabilities, Bugs or Code Smells.
  • I have added tests (unit and E2E if user-facing) that prove my fix is effective or that my feature works,
    Coverage > 80% and not less than the current coverage of the main branch.
  • The PR branch is up-to-date with the base branch. In case you merged main into your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).
  • I have included the reset.d.ts in the tsconfig.lib.json

@timonmasberg timonmasberg self-assigned this Jul 24, 2023
@timonmasberg timonmasberg marked this pull request as ready for review July 24, 2023 13:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.0% 87.0% Coverage
0.0% 0.0% Duplication

@timonmasberg timonmasberg requested a review from JSPRH July 24, 2023 13:27
@timonmasberg
Copy link
Member Author

We might want to check for duplicate warnings throughout multiple data sources (they can be redundant).

@timonmasberg timonmasberg force-pushed the main branch 2 times, most recently from 9b697ff to 99a715d Compare January 23, 2024 13:07
# Conflicts:
#	.github/actions/build-and-deploy-api/action.yml
#	.github/workflows/next-deployment.yml
#	.github/workflows/preview-deployment.yml
#	apps/api/.env.template
#	apps/api/src/app/app.module.ts
#	libs/api/auth/src/lib/interceptors/auth.interceptor.ts
#	package-lock.json
#	package.json
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant