Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: supplement items for priority and QOS validation in clusterColocationProfile. #2270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tan90github
Copy link
Contributor

Ⅰ. Describe what this PR does

After I looking over the code, the relationship between priority and QoS seems should match this table, so koordinator missing some checks in the clusterColocationProfileValidatingPod.

QoS\Priority koord-prod koord-mid koord-batch koord-free koord-none
SYSTEM
LSE
LSR
LS
BE

I hope to clarify the correct matching between priority and QoS, so that users can understand it clearly.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.07%. Comparing base (b4c53c8) to head (1688cdb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2270   +/-   ##
=======================================
  Coverage   66.06%   66.07%           
=======================================
  Files         453      453           
  Lines       53387    53389    +2     
=======================================
+ Hits        35271    35277    +6     
- Misses      15580    15581    +1     
+ Partials     2536     2531    -5     
Flag Coverage Δ
unittests 66.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube
Copy link
Member

Added an issue to revise the documentation. koordinator-sh/website#188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants