koord-descheduler: fix descheduler object limiter with multiple profiles #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: songtao98 <[email protected]>
songtao98
force-pushed
the
support_descheduler_multiple_profiles
branch
from
8a0c4bb
to
39743f8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2200 +/- ##
==========================================
- Coverage 67.72% 67.72% -0.01%
==========================================
Files 446 446
Lines 42695 42699 +4
==========================================
Hits 28916 28916
- Misses 11258 11259 +1
- Partials 2521 2524 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
koord-descheduler uses limiterMap to manage object limiters. If multiple profiles are configured, all MigrationControllers in all profiles can evict pods from all PodMigrationJobs. But a workload limiter may be recorded inside one limiterMap of a profile, but evicted by another limiterMap. This may cause object limiter not working.
This PR add a UUID to MigrationController and an Annotation to PodMigrationJob. Each time a PodMigrationJob is created by MigrationController, its UUID will be recorded into this Annotation. Each time a MigrationController from a profile reconciling a PodMigrationJob, it decide if to drop this PodMigraionJob by this annotation.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test