Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add the ability to translate annotation literals #132

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abrugaro
Copy link

Solves #129

This PR also:

  • Adds an e2e test to cover the translation of a whole rule
  • Replaces imports from github.com/fabianvf/windup-rulesets-yaml to github.com/konveyor/windup-shim as the first repo no longer exists.

Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Copy link

github-actions bot commented Sep 24, 2024

Overall success rate: 78.52% (2029/2584)

@jmle jmle self-requested a review October 2, 2024 10:00
Copy link
Contributor

@jmle jmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, just a couple of small things

data/test-rule.xml Outdated Show resolved Hide resolved
e2e_test.go Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Signed-off-by: Alejandro Brugarolas <[email protected]>
@abrugaro abrugaro requested a review from jmle October 7, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants