fix: QA categories were being used only by the CLI engine #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request! 😃 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
+ Coverage 14.86% 14.89% +0.02%
==========================================
Files 90 90
Lines 8376 8380 +4
==========================================
+ Hits 1245 1248 +3
+ Misses 6810 6809 -1
- Partials 321 323 +2 ☔ View full report in Codecov by Sentry. |
Akash-Nayak
requested review from
seshapad,
ashokponkumar and
HarikrishnanBalagopal
Akash-Nayak
force-pushed
the
update-https-engine
branch
from
91a9712
to
4973170
Compare
Co-authored-by: Harikrishnan Balagopal <[email protected]> Signed-off-by: Akash Nayak <[email protected]>
Akash-Nayak
force-pushed
the
update-https-engine
branch
from
4973170
to
c0ef8d7
Compare
HarikrishnanBalagopal
changed the title
|
Related #1154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the QA http rest engine of Move2Kube required for adding QA category enable/disable support to Move2Kube API #1155, #1151 (comment). For the disabled categories, the QA engine should automatically consider the default answer as the input answer.
Signed-off-by: Akash Nayak [email protected]