🐛 Analysis update after removing duplicated custom rules #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run Signed-off-by: John Matthews <[email protected]>
Signed-off-by: John Matthews <[email protected]>
jwmatthews
changed the title
jwmatthews
changed the title
jwmatthews
changed the title
fabianvf
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove the custom rules we were carrying in Kai as they have since been submitted to Konveyor and are present in the Kantra builds. The duplication of us carrying the rules with a different ruleset name than Konveyor caused confusion and breakage when resolving solved incidents.
This issue is explained in #299
Fixes #299
Includes a workaround for konveyor/kantra#321
Output of analysis for all the sample data captured here:
https://gist.github.com/jwmatthews/9e1e5e8368e595b5e60ecfc6d543efc3