Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Initial draft of generic authentication and authorization #182

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shawn-hurley
Copy link
Contributor

No description provided.

@jmontleon
Copy link
Member

jmontleon commented Jun 12, 2024

Does this replace or make use of the openshift auth functionality we have in the operator today?
https://github.com/konveyor/operator/blob/main/roles/tackle/tasks/main.yml#L45

It's not well tested, and maybe not even well known it is there, and to fully work I believe there'd probably need to be changes to the hub.

@shawn-hurley
Copy link
Contributor Author

Going to be honest @jmontleon I had no idea that existed, and I am not convinced that this would even work. @aufi @jortel Can someone let me know if this even is a valid option?

@jmontleon
Copy link
Member

Going to be honest @jmontleon I had no idea that existed, and I am not convinced that this would even work. @aufi @jortel Can someone let me know if this even is a valid option?

I added this. It worked at the time, but I have not tested it in a long time. It uses the OpenShift oauth-proxy. It only provided authentication, no authorization, so once authenticated you could do anything.

@shawn-hurley
Copy link
Contributor Author

Thank you for reminding me about this! I had forgetten this option. I have a feeling it still works and something that I will need to add:

  1. What to do with this option
  2. What to do IF this option is in use during upgrade

Copy link
Contributor

@rromannissen rromannissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace mentions to MTA with Konveyor


## Summary

As we move to more and more integrations with MTA, we need to consider the many different
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"As we move to more and more integrations with Konveyor"

## Motivation

As we gain both more users, and more integrations, supporting generic authentication that would exist in a company
is going to make the user experience more complete. This will enable easier setup of a secure MTA environment by allowing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This will enable easier setup of a secure Konveyor environment..."


The goal of this enhancement is to make authentication generic, such that any authentication provider that supports OAuth and OIDC is usable as authorization and authentication. The goal is for admin users to have an easy configuration, end users have some default access when logging on and when using OIDC you can map roles to internal roles. Each of these is important to keep the user experience sane and not cumbersome.

The other goal is to make integration with things like RHDH easier, by allowing users to share authentication between systems.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The other goal is to make integration with things like Backstage easier"


## Alternatives

We did consider moving to using Kubernetes built-in RBAC. The biggest drawback with this approach is that users of MTA would have to have logins for Kubernetes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The biggest drawback with this approach is that users of Konveyor would have to have logins for Kubernetes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants