Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Compose multiplatform #46

Draft
wants to merge 60 commits into
base: develop
Choose a base branch
from
Draft

Migrate to Compose multiplatform #46

wants to merge 60 commits into from

Conversation

kongwoojin
Copy link
Owner

@kongwoojin kongwoojin commented May 19, 2024 •
edited
Loading

Migrate to Compose multiplatform

Current state

  • Support Android
  • Support Desktop(JVM)
  • Support iOS

TODO

  • Implement build-logic correctly
  • Fix bugs

Current bugs

  • Table colors are not correct
  • Tables are not loaded on Desktop
  • Boards are regenerated every time when view loaded
  • Opensource licenses are missing
  • Desktop build variant is hard-coded to Debug
  • Lint failed due to generated sqldelight classes
  • Webview size is hard-coded on Desktop
  • Webview background is not transparent on Desktop

kongwoojin added 30 commits May 13, 2024 17:05
@kongwoojin
refactor: Migrate to Ktor from Retrofit2
2597e38
@kongwoojin
refactor: Replace navigation and lifecycle for multiplatform
60d8fe9
@kongwoojin
refactor: Migrate to Koin from Hilt
ed4b5c5
@kongwoojin
refactor: Remove hilt module
c38c3b5
@kongwoojin
refactor: Migrate room to sqldelight
2a8051e
@kongwoojin
refactor: Migrate to MaterialKolor
30a9fd6
@kongwoojin
chore: Remove room from data module
b5967ba
@kongwoojin
refactor: Migrate to Compose multiplatform from Jetpack compose
fbc2146
@kongwoojin
refactor: Migrate to Compose Multiplatform
fe9d0b9
@kongwoojin
fix: Fix webview not rendered on compose desktop
77d627d
@kongwoojin
fix: Fix ClassNotFoundException
b8f31c6
@kongwoojin
refactor: Use gradle-license-plugin
2c5a509
@kongwoojin
feat: Update koin to 3.6.0-Beta02 and add koin-compose-viewmodel depe…
3799f8a 
…ndency
@kongwoojin
chore: Update licenses
44ccbc6
@kongwoojin
feat: Reduce animation speed
1feffe5
@kongwoojin
feat: Show snackbar when failed to open mail app
e124413
@kongwoojin
feat: Set android build_type key for firebase
6701aeb
@kongwoojin
feat: Remove unused android dependencies from domain module
b6df4fa
@kongwoojin
feat: Update proguard rules
18baec2
@kongwoojin
fix: Fix firebase topic hard-coded to development
76efb60
@kongwoojin
chore: Bump compose version to 1.6.10
d81f849
@kongwoojin
chore: Bump lifecycle version to 2.8.0
4c88da3
@kongwoojin
chore: Bump coroutine version to 1.8.1
30b2fda
@kongwoojin
chore: Bump webkit version to 1.11.0
b7cf8b2
@kongwoojin
chore: Bump crashlytics version to 3.0.1
73de10c
@kongwoojin
fix: Remove crashlytics from data module
66f2716
@kongwoojin
feat: Enable push notification
42cb2fb
@kongwoojin
feat: Show error message
d995a73
@kongwoojin
feat: Add desktop icons
2133fd5
@kongwoojin
chore: Update icons
a733bbd
@kongwoojin kongwoojin marked this pull request as draft June 8, 2024 02:57
@kongwoojin kongwoojin marked this pull request as ready for review June 8, 2024 04:49
@kongwoojin kongwoojin marked this pull request as draft June 8, 2024 05:00
kongwoojin added 16 commits June 8, 2024 14:00
@kongwoojin
Merge branch 'develop' of https://github.com/kongwoojin/koreatech-boa…
243e484 
…rd-android into multiplatform
@kongwoojin
Merge branch 'develop' of https://github.com/kongwoojin/koreatech-boa…
cb2a098 
…rd-android into multiplatform
@kongwoojin
chore: Fix ktlint
5826135
@kongwoojin
chore: Change ArrayList to List
a818623
@kongwoojin
refactor: Use when statement instead of if
3d36413
@kongwoojin
feat: Add fixedDynamicColorScheme to fix wrong dynamic color scheme o…
2790c67 
…n One UI 6
@kongwoojin
feat: Remove material-kolor
7fb789d
@kongwoojin
feat: Remove all notification when notification clicked
45970c6
@kongwoojin
feat: Enable subscribe when notification permission granted
791ec67
@kongwoojin
feat: Use new api for widget
cf162d4
@kongwoojin
chore: Fix typo
60f6aef
@kongwoojin
chore: Rename BoardInHome composable to BoardWidget
db6ef42
@kongwoojin
chore: Remove material-kolor from libs.version.toml
d963c73
@kongwoojin
Merge branch 'develop' of https://github.com/kongwoojin/koreatech-boa…
fa94d69 
…rd-android into multiplatform
@kongwoojin
feat: Add ContextUtil for android
fcebf21
@kongwoojin
chore: Fix ktlint
e9a95db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kongwoojin