Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLDX-82): add checksum signing step #593

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

swickersh
Copy link
Contributor

This commit adds a step to the sign-binaries task to generate the sha256 sums of all the signed binaries and collect them in a single file (sha256sum.txt).
It then transfers the file to a remote host to be signed with Red Hat's GPG key. The detached signatures are returned and released alongside binaries in subsequent tasks to the RH Developer Portal.

Copy link

openshift-ci bot commented Oct 1, 2024

Hi @swickersh. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@swickersh swickersh force-pushed the checksum_signing branch 3 times, most recently from 2d71182 to 4254c0e Compare October 1, 2024 03:38
@swickersh
Copy link
Contributor Author

@mmalina @johnbieren,

When @pkhander returns from PTO next week we'll get #566 rebased.
After that he and I will run the entire push-binaries pipeline several times. We plan to submit (hopefully) one last PR at that point with any fixes we encounter. Prior to that, no products will be using this pipeline.
Thanks!

@swickersh swickersh marked this pull request as ready for review October 1, 2024 12:59
@swickersh swickersh requested a review from a team as a code owner October 1, 2024 12:59
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do you want this merged in the meantime?

@swickersh
Copy link
Contributor Author

So do you want this merged in the meantime?

Yes, I don't see any reason to not go ahead and get it reviewed/merged.

johnbieren
johnbieren previously approved these changes Oct 1, 2024
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

This commit adds a step to the sign-binaries task to generate the
sha256 sums of all the signed binaries and collect them in a single
file (sha256sum.txt).
It then transfers the file to a remote host to be signed with Red
Hat's GPG key. The detached signatures are returned and released
alongside binaries in subsequent tasks to the RH Developer Portal.

Signed-off-by: Scott Wickersham <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Oct 1, 2024
@johnbieren johnbieren enabled auto-merge (squash) October 1, 2024 19:33
@johnbieren johnbieren merged commit 5bb8935 into konflux-ci:development Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants