-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RELEASE-910): add run-collectors task #575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping CI for Draft Pull Request. |
johnbieren
force-pushed
the
release_910
branch
18 times, most recently
from
September 26, 2024 18:11
7707bd6
to
351f8c9
Compare
mmalina
reviewed
Sep 27, 2024
mmalina
reviewed
Sep 27, 2024
tasks/run-collectors/tests/test-run-collectors-no-results-dir.yaml
Outdated
Show resolved
Hide resolved
johnbieren
force-pushed
the
release_910
branch
from
September 27, 2024 12:19
351f8c9
to
06d00ef
Compare
mmalina
reviewed
Sep 27, 2024
johnbieren
force-pushed
the
release_910
branch
2 times, most recently
from
September 27, 2024 18:13
c99e0d7
to
e4f52ce
Compare
@mmalina fyi, I updated this task to run in parallel since I got it figured out before this PR was merged or others reviewed it. It isn't too different, but just wanted to give you a heads up that a bit of it changed since your review |
johnbieren
force-pushed
the
release_910
branch
3 times, most recently
from
September 30, 2024 23:49
00a45cf
to
fa7402c
Compare
mmalina
reviewed
Oct 1, 2024
johnbieren
force-pushed
the
release_910
branch
2 times, most recently
from
October 1, 2024 13:35
2b9e884
to
b224574
Compare
mmalina
reviewed
Oct 1, 2024
This commit adds a new task run-collectors which will run all defined collectors in the ReleasePlan and ReleasePlanAdmission and write the results to a passed resultsDir. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
release_910
branch
from
October 2, 2024 00:47
b224574
to
e8a40a1
Compare
mmalina
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new task run-collectors which will run all defined collectors in the ReleasePlan and ReleasePlanAdmission and write the results to a passed resultsDir.