feat(RELEASE-1102): remove unused data.fbc paremeters from the fbc tasks #554
+7
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
theflockers
force-pushed
the
release-1102
branch
2 times, most recently
from
7b069d6
to
e103f4e
Compare
|
/test all |
theflockers
force-pushed
the
release-1102
branch
from
e103f4e
to
988b911
Compare
mmalina
reviewed
Sep 16, 2024
johnbieren
reviewed
Sep 16, 2024
theflockers
force-pushed
the
release-1102
branch
from
0f3ff6d
to
b30a52f
Compare
mmalina
previously approved these changes
Sep 17, 2024
theflockers
force-pushed
the
release-1102
branch
from
b30a52f
to
af6be30
Compare
johnbieren
previously approved these changes
Sep 17, 2024
|
Must also merge hacbs-release/app-interface-deployments#186 |
theflockers
force-pushed
the
release-1102
branch
from
af6be30
to
f083e8c
Compare
|
/test release-pipelines-e2e-suite |
theflockers
force-pushed
the
release-1102
branch
from
f083e8c
to
7fd6602
Compare
theflockers
force-pushed
the
release-1102
branch
from
7fd6602
to
5b482d5
Compare
theflockers
force-pushed
the
release-1102
branch
from
5b482d5
to
55d62be
Compare
johnbieren
approved these changes
Sep 27, 2024
theflockers
force-pushed
the
release-1102
branch
from
55d62be
to
59dd4ca
Compare
|
New changes are detected. LGTM label has been removed. |
theflockers
force-pushed
the
release-1102
branch
from
59dd4ca
to
a099ddf
Compare
this commit removes references of unused or unecessary parameters in FBC Release Pipeline and tasks, namely: iibServiceConfigSecret, iibServiceAccountSecret and iibOverwriteFromIndexCredential. Signed-off-by: Leandro Mendes <[email protected]>
theflockers
force-pushed
the
release-1102
branch
from
a099ddf
to
44ace49
Compare
|
/retest |
1 similar comment
|
/retest |
|
/test release-pipelines-e2e-suite |
1 similar comment
|
/test release-pipelines-e2e-suite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit removes references of unused or unecessary parameters in FBC Release Pipeline and tasks, namely: iibServiceConfigSecret, and iibOverwriteFromIndexCredential.